Fokko commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1307183313
##########
python/pyarrow/types.pxi:
##########
@@ -3173,6 +3215,9 @@ def unify_schemas(schemas):
----------
schemas : list of Schema
Schemas to merge into a single one.
+ options : FieldMergeOptions or string, optional
Review Comment:
Hmm, maybe this 🚢 has sailed already. It is also called options in
`cast(target_schema, safe, options)`, I like the consistency there
##########
python/pyarrow/types.pxi:
##########
@@ -3173,6 +3215,9 @@ def unify_schemas(schemas):
----------
schemas : list of Schema
Schemas to merge into a single one.
+ options : FieldMergeOptions or string, optional
Review Comment:
Hmm, maybe this 🚢 has sailed already. It is also called options in
`cast(target_schema, safe, options)`, I like the consistency there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
