Fokko commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1307200018
##########
python/pyarrow/table.pxi:
##########
@@ -5042,9 +5043,14 @@ def concat_tables(tables, c_bool promote=False,
MemoryPool memory_pool=None):
tables : iterable of pyarrow.Table objects
Pyarrow tables to concatenate into a single Table.
promote : bool, default False
- If True, concatenate tables with null-filling and null type promotion.
+ If True, concatenate tables with null-filling and type promotion.
+ See field_merge_options for the type promotion behavior.
Review Comment:
> Essentially the promote=False can be seen as a "no promotion" field merge
option?
This is correct, it will only do null-filling for missing columns.
The problem is that the `promote` is only relevant when merging tables, when
just upcasting fields, then you don't need this, therefore `merge_options`
might not be the best place to put it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
