jorisvandenbossche commented on code in PR #37097:
URL: https://github.com/apache/arrow/pull/37097#discussion_r1308733989


##########
python/pyarrow/_dataset.pyx:
##########
@@ -1838,7 +1838,7 @@ cdef class FileFragment(Fragment):
             typ = ""
         partition_dict = get_partition_keys(self.partition_expression)
         partition = ", ".join(
-            [f"{key}={val}" for key, val in partition_dict.items()]
+            sorted([f"{key}={val}" for key, val in partition_dict.items()])

Review Comment:
   Sorry, forgot to answer here: I somehow thought this was the path, but it's 
a separate list of partition key/values. For those I suppose the order is 
indeed not strictly important. 
   But since you already updated the test to deal with it in the meantime, 
let's leave it at that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to