jorisvandenbossche commented on code in PR #37097: URL: https://github.com/apache/arrow/pull/37097#discussion_r1310502578
########## python/pyarrow/includes/libarrow_fs.pxd: ########## @@ -23,7 +23,7 @@ from pyarrow.includes.libarrow_python cimport CTimePoint cdef extern from "arrow/filesystem/api.h" namespace "arrow::fs" nogil: - ctypedef enum CFileType "arrow::fs::FileType": + ctypedef enum CFileType "arrow::fs::FileType": # numpydoc ignore=PR01 Review Comment: > Can't we somehow indicate to numpydoc to skip those from the command line? I wouldn't put too much effort in this .. Hmm, that might need some changes in the archery numpydoc integration .. (you can currently select a subset / module to test, but not exclude parts) Looking at the numpydoc documentation, they indicate that the ignore commands also only work for "the CLI, pre-commit hook, and Sphinx extension" (https://numpydoc.readthedocs.io/en/latest/validation.html#ignoring-validation-checks-with-inline-comments), while I think archery uses their python API directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
