wgtmac commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1309672814
##########
cpp/src/parquet/properties.h:
##########
@@ -186,6 +200,24 @@ class PARQUET_EXPORT ColumnProperties {
page_index_enabled_ = page_index_enabled;
}
+ void set_bloom_filter_options(std::optional<BloomFilterOptions>
bloom_filter_options) {
+ if (bloom_filter_options) {
+ if (bloom_filter_options->fpp > 1.0 || bloom_filter_options->fpp < 0.0) {
+ throw ParquetException(
+ "Bloom Filter False positive probability must be between 0.0 and
1.0");
+ }
+ }
+ bloom_filter_options_ = bloom_filter_options;
+ }
+
+ void set_bloom_filter_enabled(bool bloom_filter_enabled) {
Review Comment:
I think `void set_bloom_filter_options(BloomFilterOptions
bloom_filter_options);` is enough. It is disabled by default and we don't need
an extra function to disable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
