mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1309680232
##########
cpp/src/parquet/properties.h:
##########
@@ -186,6 +200,24 @@ class PARQUET_EXPORT ColumnProperties {
page_index_enabled_ = page_index_enabled;
}
+ void set_bloom_filter_options(std::optional<BloomFilterOptions>
bloom_filter_options) {
+ if (bloom_filter_options) {
+ if (bloom_filter_options->fpp > 1.0 || bloom_filter_options->fpp < 0.0) {
+ throw ParquetException(
+ "Bloom Filter False positive probability must be between 0.0 and
1.0");
+ }
+ }
+ bloom_filter_options_ = bloom_filter_options;
+ }
+
+ void set_bloom_filter_enabled(bool bloom_filter_enabled) {
Review Comment:
Yeah I agree.( I still think we should add a disable here for stable testing
or config it in Python and other SDK)
And I agree `enable_bloom_filter` is not a good idea. Currently user should
better have a self-given ndv rather than a default huge value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
