danepitkin commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1313230005
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -69,4 +74,77 @@ public Optional<String[]> getColumns() {
public long getBatchSize() {
return batchSize;
}
+
+ public Optional<ByteBuffer> getSubstraitExpressionProjection() {
+ return substraitExpressionProjection;
+ }
+
+ public Optional<ByteBuffer> getSubstraitExpressionFilter() {
+ return substraitExpressionFilter;
+ }
Review Comment:
Can we call these `substrait_projection` and `substrait_filter`? I think we
can either leave out the word "expression" or else change it to
"susbstrait_extended_expression_X" if we want to be verbose. I'm curious if
other folks have thoughts on readability. Substrait will probably be a new
concept to many Arrow Java users so I think it would be good to have consistent
and clear naming here.
If we change the naming, it would be best to change it everywhere e.g. in
JNI/C++, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
