danepitkin commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1323164894
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -69,4 +74,77 @@ public Optional<String[]> getColumns() {
public long getBatchSize() {
return batchSize;
}
+
+ public Optional<ByteBuffer> getSubstraitProjection() {
+ return substraitProjection;
+ }
+
+ public Optional<ByteBuffer> getSubstraitFilter() {
+ return substraitFilter;
+ }
+
+ /**
+ * Builder for Options used during scanning.
+ */
+ public static class Builder {
+ private final long batchSize;
+ private Optional<String[]> columns;
+ private Optional<ByteBuffer> substraitProjection;
+ private Optional<ByteBuffer> substraitFilter;
+
+ /**
+ * Constructor.
+ * @param batchSize Maximum row number of each returned {@link
org.apache.arrow.vector.ipc.message.ArrowRecordBatch}
+ */
+ public Builder(long batchSize) {
+ this.batchSize = batchSize;
+ }
+
+ /**
+ * Set the Projected columns. Empty for scanning all columns.
+ *
+ * @param columns Projected columns. Empty for scanning all columns.
+ * @return the ScanOptions configured.
+ */
+ public Builder columns(Optional<String[]> columns) {
Review Comment:
One more thing: We don't need `Optional<>` parameters for the builder APIs.
We should expect the user to passing us a valid object. Same with
`substraitProjection` and `substraitFilter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
