Joseph-Rance opened a new pull request, #4773:
URL: https://github.com/apache/arrow-rs/pull/4773

   # Which issue does this PR close?
   Closes #4772.
   
   # What changes are included in this PR?
    - Added a `parquet::record::RecordReader` trait similar to the existing 
`parquet::record::RecordWriter`
    - Added a `parquet_derive::ParquetRecordReader` derive macro to implement 
the new `RecordReader` trait for slices of structs, similar to the existing 
`parquet_derive::ParquetRecordWriter` macro
    - Added tests to `parquet_field.rs` for `reader_snipped` similar to the 
existing tests for `writer_snipped`
    - Added a test to `parqued_derive_test` to test writing a struct slice to a 
parquet file, reading it again, and then checking the output is the same as the 
original struct.
    - Not all types supported by `ParquetRecordWriter` are supported by 
`ParquetRecordReader` yet. Specifically there is no support for options or 
references. References is difficult because using `Rc` would mean we have to 
manually annotate types for the compiler which requires quite a lot of matching 
on the `Field`'s `ty` field. See: 
https://github.com/Joseph-Rance/arrow-rs/blob/f49472eb93c4bf27aa20d8040c57539fc73d1059/parquet_derive/src/parquet_field.rs#L452-L454
   
    - Updated the readme to reflect the above point
   
   # Are there any user-facing changes?
    - Users will now have access to the `parquet::record::RecordReader` trait 
and the `parquet_derive::ParquetRecordReader` proc macro
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to