Joseph-Rance commented on code in PR #4773:
URL: https://github.com/apache/arrow-rs/pull/4773#discussion_r1328689559
##########
parquet_derive/src/parquet_field.rs:
##########
@@ -354,6 +428,50 @@ impl Field {
}
}
+ fn copied_direct_fields(&self) -> proc_macro2::TokenStream {
+ let field_name = &self.ident;
+ let is_a_byte_buf = self.is_a_byte_buf;
+ let is_a_timestamp =
+ self.third_party_type == Some(ThirdPartyType::ChronoNaiveDateTime);
+ let is_a_date = self.third_party_type ==
Some(ThirdPartyType::ChronoNaiveDate);
+ let is_a_uuid = self.third_party_type == Some(ThirdPartyType::Uuid);
+
+ let value = if is_a_timestamp {
Review Comment:
I did this to mirror what already exists in `copied_direct_vals`, and I
agree match would be nicer so I'll update both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
