benibus commented on code in PR #37418:
URL: https://github.com/apache/arrow/pull/37418#discussion_r1316108410
##########
cpp/src/arrow/compute/registry.cc:
##########
@@ -276,6 +276,7 @@ static std::unique_ptr<FunctionRegistry>
CreateBuiltInRegistry() {
// Register core kernels
RegisterScalarCast(registry.get());
RegisterDictionaryDecode(registry.get());
+ RegisterDictionaryCompaction(registry.get());
Review Comment:
Do we actually want to register these here or should that be done in the
`#if ARROW_COMPUTE` block below? Generally speaking, the "core" kernel library
is limited to casts and their dependencies - although there are a few
exceptions.
Granted, I'm pretty sure doing that would also necessitate moving the tests
out of `vector_hash_test.cc` since it's built/run unconditionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
