benibus commented on code in PR #37418:
URL: https://github.com/apache/arrow/pull/37418#discussion_r1317558416
##########
cpp/src/arrow/compute/registry.cc:
##########
@@ -276,6 +276,7 @@ static std::unique_ptr<FunctionRegistry>
CreateBuiltInRegistry() {
// Register core kernels
RegisterScalarCast(registry.get());
RegisterDictionaryDecode(registry.get());
+ RegisterDictionaryCompaction(registry.get());
Review Comment:
> Sorry, I have no consideration on these.
Understandable. The whole situation isn't really ideal at the moment...
> Do we need to create new files `vector_dictionary.cc` and
`vector_dictionary_test.cc`?
You _could_ get away with only moving the tests, but creating
`vector_dictionary.cc` would be better. Just make sure it's added to the
appropriate section in the CMakeLists:
https://github.com/R-JunmingChen/arrow/blob/46959c21d2ca6a2bdd8026e407c90a34b907fdb6/cpp/src/arrow/CMakeLists.txt#L434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
