kazuyukitanimura commented on code in PR #7400:
URL: https://github.com/apache/arrow-datafusion/pull/7400#discussion_r1316579469
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -178,6 +240,28 @@ pub(crate) struct GroupedHashAggregateStream {
/// Have we seen the end of the input
input_done: bool,
+
Review Comment:
Done
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -374,15 +519,29 @@ impl RecordBatchStream for GroupedHashAggregateStream {
impl GroupedHashAggregateStream {
/// Perform group-by aggregation for the given [`RecordBatch`].
- fn group_aggregate_batch(&mut self, batch: RecordBatch) -> Result<()> {
+ fn group_aggregate_batch(&mut self, batch: RecordBatch, merging: bool) ->
Result<()> {
// Evaluate the grouping expressions
- let group_by_values = evaluate_group_by(&self.group_by, &batch)?;
+ let group_by_values = if merging {
+ let group_by =
PhysicalGroupBy::new_single(self.group_by.expr.clone());
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
