kazuyukitanimura commented on code in PR #7400: URL: https://github.com/apache/arrow-datafusion/pull/7400#discussion_r1326480317
########## datafusion/core/src/physical_plan/aggregates/row_hash.rs: ########## @@ -120,6 +151,56 @@ use super::AggregateExec; /// hash table). /// /// [`group_values`]: Self::group_values +/// +/// # Spilling +/// +/// The sizes of group values and accumulators can become large. Before that causes out of memory, +/// this hash aggregator outputs those data early for partial aggregation or spills to local disk +/// using Arrow IPC format for final aggregation. For every input [`RecordBatch`], the memory +/// manager checks whether the new input size meets the memory configuration. If not, outputting or +/// spilling happens. For outputting, the final aggregation takes care of re-grouping. For spilling, Review Comment: Looks you already got it, but just for record. A few lines above, I think this line addresses your question ``` this hash aggregator outputs those data early for partial aggregation or spills to local disk using Arrow IPC format for final aggregation. ``` ########## datafusion/core/src/physical_plan/aggregates/row_hash.rs: ########## @@ -120,6 +151,56 @@ use super::AggregateExec; /// hash table). /// /// [`group_values`]: Self::group_values +/// +/// # Spilling +/// +/// The sizes of group values and accumulators can become large. Before that causes out of memory, +/// this hash aggregator outputs those data early for partial aggregation or spills to local disk +/// using Arrow IPC format for final aggregation. For every input [`RecordBatch`], the memory +/// manager checks whether the new input size meets the memory configuration. If not, outputting or +/// spilling happens. For outputting, the final aggregation takes care of re-grouping. For spilling, Review Comment: Looks you already got it, but just for the record. A few lines above, I think this line addresses your question ``` this hash aggregator outputs those data early for partial aggregation or spills to local disk using Arrow IPC format for final aggregation. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
