jorgecarleitao commented on a change in pull request #9093:
URL: https://github.com/apache/arrow/pull/9093#discussion_r551739520
##########
File path: rust/arrow/src/array/data.rs
##########
@@ -136,6 +137,84 @@ impl ArrayData {
&self.null_bitmap
}
+ /// Computes the logical validity bitmap of the array data using the
+ /// parent's array data. The parent should be a list or struct, else
+ /// the logical bitmap of the array is returned unaltered.
+ ///
+ /// Parent data is passed along with the parent's logical bitmap, as
+ /// nested arrays could have a logical bitmap different to the physical
+ /// one on the `ArrayData`.
+ ///
+ /// Safety
+ ///
+ /// As we index into [`ArrayData::child_data`], this function panics if
+ /// array data is not a nested type, as it will not have child data.
+ pub fn child_logical_null_buffer(
Review comment:
I would have placed this function outside of `impl ArrayData`, add the
corresponding arguments, and place it under `equal/utils.rs` for now.
Alternatively, use `pub(crate)` to not make this public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
