nevi-me commented on a change in pull request #9093:
URL: https://github.com/apache/arrow/pull/9093#discussion_r551745156
##########
File path: rust/arrow/src/array/equal/mod.rs
##########
@@ -146,118 +146,103 @@ fn equal_values(
rhs_start: usize,
len: usize,
) -> bool {
- // compute the nested buffer of the parent and child
- // if the array has no parent, the child is computed with itself
- #[allow(unused_assignments)]
- let mut temp_lhs: Option<Buffer> = None;
- #[allow(unused_assignments)]
- let mut temp_rhs: Option<Buffer> = None;
- let lhs_merged_nulls = match (lhs_nulls, lhs.null_buffer()) {
- (None, None) => None,
- (None, Some(c)) => Some(c),
- (Some(p), None) => Some(p),
- (Some(p), Some(c)) => {
- let merged = (p & c).unwrap();
- temp_lhs = Some(merged);
- temp_lhs.as_ref()
- }
- };
Review comment:
Interestingly, I found an issue with this while fixing the failing
integration tests. See my latest commit
https://github.com/apache/arrow/pull/9093/commits/66bb98e240f9ca49a7abe2a00ce83a117a62b426.
I'll follow up with changes for your suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
