kou commented on code in PR #37603: URL: https://github.com/apache/arrow/pull/37603#discussion_r1319264104
########## cpp/CMakeLists.txt: ########## @@ -533,6 +533,9 @@ set(ARROW_TESTING_PC_LIBS "") set(ARROW_TESTING_PC_REQUIRES "") # For parquet.pc. +set(PARQUET_PC_CFLAGS "") +set(PARQUET_PC_CFLAGS_PRIVATE " -DPARQUET_STATIC") Review Comment: This is not a hack. This is a normal `.pc` usage. > Or `Cflags.private` requires only static linking? Right. `pkg-config --cflags parquet` uses only `Cflags` and `pkg-config --cflags --static parquet` uses both of `Cflags` and `Cflags.private`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
