kou commented on code in PR #37603: URL: https://github.com/apache/arrow/pull/37603#discussion_r1319300351
########## r/configure: ########## Review Comment: @assignUser FYI: Changes for this file are for using pkg-config for not only `arrow.pc` but also `parquet.pc`/`arrow-dataset.pc`/`arrow-acero.pc`/`arrow-substrait.pc`. `libarrow.a` doesn't depend on Thrift. `libparquet.a` depends on Thrift. So I removed `thrift` from `Requires.private` of `arrow.pc` by #37399. But I forgot to add `thrift` to `Requires.private` of `parquet.pc`. This is fixed by other changes in this PR. But R failures weren't fixed because `r/configure` uses pkg-config only for `arrow.pc`. `Requires.private: thrift` in `parquet.pc` wasn't used. So I also changed `r/configure` to use pkg-config for `parquet.pc`/`arrow-dataset.pc`/`arrow-acero.pc`/`arrow-substrait.pc` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
