wjones127 opened a new pull request, #4808:
URL: https://github.com/apache/arrow-rs/pull/4808

   # Which issue does this PR close?
   
   Closes #4807.
   
   # Rationale for this change
    
   The "entries" field shouldn't be nullable:
   
   
https://github.com/apache/arrow/blob/c4b01c60fba85bbfc3a1b1510e179153c0f79515/format/Schema.fbs#L124
   
   Elsewhere, we have this as false already:
   
   https://github.com/apache/arrow-rs/blob/master/arrow-schema/src/field.rs#L230
   
   The inconsistency on this causes schema mismatch issues, such as those 
documented in:
   
   https://github.com/delta-io/delta-rs/issues/1619
   
   # What changes are included in this PR?
   
   Changes all functions that construct the `"entries"` field to be 
non-nullable.
   
   # Are there any user-facing changes?
   
   Yes, this will change the type output by the `MapType::new_from_strings()` 
and `canonicalize_schema()` functions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to