wjones127 commented on code in PR #4808:
URL: https://github.com/apache/arrow-rs/pull/4808#discussion_r1320671560
##########
arrow-ipc/src/reader.rs:
##########
@@ -1487,7 +1487,7 @@ mod tests {
let keys_field = Arc::new(Field::new_dict(
"keys",
DataType::Dictionary(Box::new(DataType::Int8),
Box::new(DataType::Utf8)),
- true,
+ true, // It is technically not legal for this field to be null.
Review Comment:
The test itself has null values in the test case. Perhaps I should modify
the test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
