mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1321338613
##########
cpp/src/parquet/column_writer.h:
##########
@@ -143,7 +143,8 @@ class PARQUET_EXPORT ColumnWriter {
static std::shared_ptr<ColumnWriter> Make(ColumnChunkMetaDataBuilder*,
std::unique_ptr<PageWriter>,
- const WriterProperties*
properties);
+ const WriterProperties* properties,
+ BloomFilter* bloom_filter =
NULLPTR);
Review Comment:
`ColumnWriter` is an `PARQUET_EXPORT`, so it's export to user and we need to
considering the compatiblility. should I add a new function here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
