mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1321345290
##########
cpp/src/parquet/properties.h:
##########
@@ -532,6 +563,43 @@ class PARQUET_EXPORT WriterProperties {
return this->disable_statistics(path->ToDotString());
}
+ /// Disable bloom filter for the column specified by `path`.
+ /// Default disabled.
+ Builder* disable_bloom_filter(const std::string& path) {
+ bloom_filter_options_[path] = std::nullopt;
+ return this;
+ }
+
+ /// Disable bloom filter for the column specified by `path`.
+ /// Default enabled.
+ Builder* disable_bloom_filter(const std::shared_ptr<schema::ColumnPath>&
path) {
+ return this->disable_bloom_filter(path->ToDotString());
+ }
+
+ /// Enable bloom filter options for the column specified by `path`.
+ ///
+ /// Default disabled.
+ ///
+ /// Note: Currently we don't support bloom filter for boolean columns,
+ /// so if enable bloom filter for boolean columns, it will be ignored.
+ Builder* enable_bloom_filter_options(BloomFilterOptions
bloom_filter_options,
+ const std::string& path) {
+ bloom_filter_options_[path] = bloom_filter_options;
+ return this;
+ }
+
+ /// Enable bloom filter options for the column specified by `path`.
+ ///
+ /// Default disabled.
+ ///
+ /// Note: Currently we don't support bloom filter for boolean columns,
Review Comment:
Emmm, @wgtmac I didn't finy parquet spec about boolean variable (
https://github.com/apache/parquet-format/blob/master/BloomFilter.md )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
