alamb commented on PR #7525:
URL: 
https://github.com/apache/arrow-datafusion/pull/7525#issuecomment-1715777845

   Thanks @sarutak  -- that makes sense.
   
   > Or, is it better to add the test data to arrow-testing first?
   
   I suggest we add the data to arrow-testing first. I would feel much more 
comfortable merging code into datafusion that is tested, not only to prevent 
regressions, but also as part of reviewing unfamiliar code, having at test 
demonstrating it working is a major part of evaluating its suitability.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to