alamb commented on code in PR #7538:
URL: https://github.com/apache/arrow-datafusion/pull/7538#discussion_r1324372245
##########
datafusion/execution/src/disk_manager.rs:
##########
@@ -71,11 +72,11 @@ impl DiskManagerConfig {
/// while processing dataset larger than available memory.
#[derive(Debug)]
pub struct DiskManager {
- /// TempDirs to put temporary files in.
+ /// Dirs to put temporary files in.
///
- /// If `Some(vec![])` a new OS specified temporary directory will be
created
+ /// If `Some(vec![])` temporary files will be created in the directories.
/// If `None` an error will be returned (configured not to spill)
- local_dirs: Mutex<Option<Vec<TempDir>>>,
+ local_dirs: Mutex<Option<Vec<PathBuf>>>,
Review Comment:
Am I correct in understanding that the implication here is that the
directories in `local_dirs` will not be removed (though all the contents will
be removed, when the `NamedTempFile` are dropped)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
