sarutak commented on PR #7538: URL: https://github.com/apache/arrow-datafusion/pull/7538#issuecomment-1717472933
Thank you for the comment @alamb . > I am not sure if you have seen the fix for the test from @viirya in https://github.com/apache/arrow-datafusion/pull/7534 I've seen that PR but I don't think it's just an issue of the test. > I think this is the solution that we should pursue as it is the easiest to use long term. Perhaps we can change the API to return something like This is what I implied. If we can change the API, I'll propose the second solution. > Another potential solution I thought of was to pass a reference to the DiskManager to read_spill_as_stream to prevent the file from being deleted Yes, I also thought of this solution. But I thought it's too much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
