zeroshade commented on code in PR #37468:
URL: https://github.com/apache/arrow/pull/37468#discussion_r1324810645
##########
go/arrow/array/concat.go:
##########
@@ -483,6 +587,18 @@ func concat(data []arrow.ArrayData, mem memory.Allocator)
(arr arrow.ArrayData,
if err != nil {
return nil, err
}
+ case *arrow.ListViewType:
+ offsetType :=
arrow.PrimitiveTypes.Int32.(arrow.FixedWidthDataType)
Review Comment:
you shouldn't have to explicitly cast to the interface type here, since
`arrow.PrimitiveTypes.Int32` implements the `FixedWidthDataType` interface you
should be able to just pass it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
