zeroshade commented on code in PR #37468:
URL: https://github.com/apache/arrow/pull/37468#discussion_r1326447311
##########
go/arrow/array/concat.go:
##########
@@ -483,6 +587,18 @@ func concat(data []arrow.ArrayData, mem memory.Allocator)
(arr arrow.ArrayData,
if err != nil {
return nil, err
}
+ case *arrow.ListViewType:
+ offsetType :=
arrow.PrimitiveTypes.Int32.(arrow.FixedWidthDataType)
Review Comment:
Ah! darn me only declaring it as a `DataType` instead of actually as a
`FixedWidthDataType` despite it implementing it. *sigh* Essentially you *could*
do `&arrow.Int32Type{}` but that would be creating a new instance rather than
using the existing one.
I'd consider using the more specific interface type in the declared vars but
I don't want to potentially break anyone who's already doing this type
assertion....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
