alamb commented on code in PR #7432:
URL: https://github.com/apache/arrow-datafusion/pull/7432#discussion_r1326461193
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -262,25 +262,25 @@ pub(crate) struct AggregationOrdering {
#[derive(Debug)]
pub struct AggregateExec {
/// Aggregation mode (full, partial)
- pub(crate) mode: AggregateMode,
Review Comment:
> I'm not sure about this, do we want/need to expose the internals of a
physical operator externally?
The short answer is there are things in the physical optimizer passes that
use these fields directly (I think mostly as a convenience). I will make a real
API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
