alamb commented on code in PR #7432:
URL: https://github.com/apache/arrow-datafusion/pull/7432#discussion_r1326517799
##########
datafusion/core/src/test/mod.rs:
##########
@@ -359,15 +297,88 @@ pub fn csv_exec_sorted(
))
}
-/// Create batch
-fn create_batch(schema: &Schema) -> RecordBatch {
- RecordBatch::try_new(
- Arc::new(schema.clone()),
- vec![Arc::new(UInt32Array::from(vec![1, 2, 3, 4, 5, 6, 7, 8]))],
- )
- .unwrap()
+/// A mock execution plan that simply returns the provided statistics
+#[derive(Debug, Clone)]
+pub struct StatisticsExec {
Review Comment:
I am not sure -- there are defiitely some areas that would be nice to clean
up with respect to testing
##########
datafusion/core/src/test/mod.rs:
##########
@@ -359,15 +297,88 @@ pub fn csv_exec_sorted(
))
}
-/// Create batch
-fn create_batch(schema: &Schema) -> RecordBatch {
- RecordBatch::try_new(
- Arc::new(schema.clone()),
- vec![Arc::new(UInt32Array::from(vec![1, 2, 3, 4, 5, 6, 7, 8]))],
- )
- .unwrap()
+/// A mock execution plan that simply returns the provided statistics
+#[derive(Debug, Clone)]
+pub struct StatisticsExec {
Review Comment:
I am not sure -- there are definitely some areas that would be nice to clean
up with respect to testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
