kazuyukitanimura commented on code in PR #7400:
URL: https://github.com/apache/arrow-datafusion/pull/7400#discussion_r1326499115
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -318,9 +433,12 @@ impl Stream for GroupedHashAggregateStream {
assert!(!self.input_done);
if let Some(to_emit) =
self.group_ordering.emit_to() {
- let batch = extract_ok!(self.emit(to_emit));
+ let batch = extract_ok!(self.emit(to_emit,
false));
self.exec_state =
ExecutionState::ProducingOutput(batch);
}
+
+ extract_ok!(self.emit_early_if_necessary());
Review Comment:
`self.group_ordering.emit_to()` may return `None` for all
`GroupOrdering::None`, `::Partial`, and `::Full`.
I plan to add a support for other group ordering in
self.emit_early_if_necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
