kou commented on code in PR #37725:
URL: https://github.com/apache/arrow/pull/37725#discussion_r1326861806
##########
matlab/src/matlab/+arrow/+type/Type.m:
##########
@@ -41,6 +42,29 @@
function typeID = get.ID(obj)
typeID = arrow.type.ID(obj.Proxy.getTypeID());
end
+
+ function F = field(obj, idx)
Review Comment:
`getField` may be better.
##########
matlab/src/cpp/arrow/matlab/error/error.h:
##########
@@ -195,6 +192,6 @@ namespace arrow::matlab::error {
static const char* CHUNKED_ARRAY_MAKE_FAILED =
"arrow:chunkedarray:MakeFailed";
static const char* CHUNKED_ARRAY_NUMERIC_INDEX_WITH_EMPTY_CHUNKED_ARRAY =
"arrow:chunkedarray:NumericIndexWithEmptyChunkedArray";
static const char* CHUNKED_ARRAY_INVALID_NUMERIC_CHUNK_INDEX =
"arrow:chunkedarray:InvalidNumericChunkIndex";
-
-
+ static const char* ARROW_NUMERIC_INDEX_ZERO_FIELDS =
"arrow:index:NumericIndexWithZeroFields";
+ static const char* ARROW_INVALID_NUMERIC_FIELD_INDEX =
"arrow:index:InvalidNumericFieldIndex";
Review Comment:
`INDEX_XXX = "..."` may be better because (most) other constant names have
the `XXX` part in `arrow:XXX:YYY` and doesn't have `ARROW_` prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
