sgilmore10 commented on code in PR #37725:
URL: https://github.com/apache/arrow/pull/37725#discussion_r1327438030
##########
matlab/src/matlab/+arrow/+type/Type.m:
##########
@@ -41,6 +42,29 @@
function typeID = get.ID(obj)
typeID = arrow.type.ID(obj.Proxy.getTypeID());
end
+
+ function F = field(obj, idx)
Review Comment:
That's a good point. However, if we renamed `field` to `getField`, it would
be inconsistent with other method names, such as `column`, `chunk`, etc. I'll
make an issue and link it below to consider the naming of these methods.
##########
matlab/src/cpp/arrow/matlab/error/error.h:
##########
@@ -195,6 +192,6 @@ namespace arrow::matlab::error {
static const char* CHUNKED_ARRAY_MAKE_FAILED =
"arrow:chunkedarray:MakeFailed";
static const char* CHUNKED_ARRAY_NUMERIC_INDEX_WITH_EMPTY_CHUNKED_ARRAY =
"arrow:chunkedarray:NumericIndexWithEmptyChunkedArray";
static const char* CHUNKED_ARRAY_INVALID_NUMERIC_CHUNK_INDEX =
"arrow:chunkedarray:InvalidNumericChunkIndex";
-
-
+ static const char* ARROW_NUMERIC_INDEX_ZERO_FIELDS =
"arrow:index:NumericIndexWithZeroFields";
+ static const char* ARROW_INVALID_NUMERIC_FIELD_INDEX =
"arrow:index:InvalidNumericFieldIndex";
Review Comment:
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
