jonahgao commented on code in PR #7568:
URL: https://github.com/apache/arrow-datafusion/pull/7568#discussion_r1326993019
##########
datafusion/core/tests/sql/mod.rs:
##########
@@ -634,7 +634,7 @@ pub fn make_partition(sz: i32) -> RecordBatch {
/// Specialised String representation
fn col_str(column: &ArrayRef, row_index: usize) -> String {
- if column.is_null(row_index) {
+ if column.data_type() == &DataType::Null || column.is_null(row_index) {
Review Comment:
The `abs` function may now return a
[NullArray](https://github.com/apache/arrow-rs/blob/7355e8392d6e82c28cc54236d79b4dc56d7226d4/arrow-array/src/array/null_array.rs#L45).
For example: `SELECT abs(NULL)`.
And `is_null()` does not work on NullArray.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
