jonahgao commented on code in PR #7568:
URL: https://github.com/apache/arrow-datafusion/pull/7568#discussion_r1327918198
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -883,14 +883,14 @@ mod test {
fn scalar_function() -> Result<()> {
let empty = empty();
let lit_expr = lit(10i64);
- let fun: BuiltinScalarFunction = BuiltinScalarFunction::Abs;
+ let fun: BuiltinScalarFunction = BuiltinScalarFunction::Acos;
Review Comment:
Thank you @Weijun-H ❤️ .
But I think that the purpose of the test here is not the `abs` function, but
rather type coercion (such as Int64->Float64).
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -883,14 +883,14 @@ mod test {
fn scalar_function() -> Result<()> {
let empty = empty();
let lit_expr = lit(10i64);
- let fun: BuiltinScalarFunction = BuiltinScalarFunction::Abs;
+ let fun: BuiltinScalarFunction = BuiltinScalarFunction::Acos;
Review Comment:
Thank you @Weijun-H ❤️ .
But I think that the purpose of the test here is not the `abs` function, but
rather type coercion (such as Int64->Float64).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
