mapleFU commented on code in PR #37713:
URL: https://github.com/apache/arrow/pull/37713#discussion_r1327121260
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1472,36 +1515,9 @@ class ObjectOutputStream final : public io::OutputStream
{
RETURN_NOT_OK(UploadPart("", 0));
}
+ auto self = shared_from_this();
Review Comment:
Another problem is that we cannot call `shared_from_this` in dtor (
https://stackoverflow.com/questions/28338978/stdenable-shared-from-this-is-it-allowed-to-call-shared-from-this-in-destru
), so I separate a `FinishPartUploadAfterFlush`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
