bkietz commented on PR #37713: URL: https://github.com/apache/arrow/pull/37713#issuecomment-1724150628
`dynamic_pointer_cast` is indeed necessary to move `shared_from_this` to `FileInterface`. AFAIU, this shouldn't cause any problems (technically `enable_shared_from_this` will not be a virtual base, only `FileInterface` is); `enable_shared_from_this` is usually implemented as a data member [private weak pointer to itself](https://github.com/llvm/llvm-project/blob/main/libcxx/include/__memory/shared_ptr.h#L1914) so we don't need to worry about `offsetof` hackery falling down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
