WillAyd commented on code in PR #1058:
URL: https://github.com/apache/arrow-adbc/pull/1058#discussion_r1327432295
##########
c/driver/postgresql/postgresql_test.cc:
##########
@@ -432,11 +429,14 @@ TEST_F(PostgresConnectionTest,
GetObjectsGetAllFindsForeignKey) {
<< "expected 1 constraint on adbc_fkey_test table, found: "
<< table->n_table_constraints;
+ const std::string version =
+ adbc_validation::GetDriverVendorVersion(&connection, &error);
+ // ASSERT_EQ(ADBC_STATUS_OK, &error);
Review Comment:
This isn't right but I couldn't find the proper pattern to use. Seems like
all of the other methods in util that could fail are `void` and raise directly.
Should I make this function also void and just mutate a buffer, or is there a
simpler pattern for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
