WillAyd commented on code in PR #1058:
URL: https://github.com/apache/arrow-adbc/pull/1058#discussion_r1327505017
##########
c/driver/postgresql/connection.cc:
##########
@@ -654,10 +652,23 @@ AdbcStatusCode PostgresConnectionGetInfoImpl(const
uint32_t* info_codes,
RAISE_ADBC(
AdbcConnectionGetInfoAppendString(array, info_codes[i],
"PostgreSQL", error));
break;
- case ADBC_INFO_VENDOR_VERSION:
- RAISE_ADBC(AdbcConnectionGetInfoAppendString(
- array, info_codes[i], std::to_string(PQlibVersion()).c_str(),
error));
Review Comment:
For future reference it appears PQlibVersion returns the libpq version of
the client, not the server. Makes sense but not something I thought about
previously
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
