Ted-Jiang commented on code in PR #7570: URL: https://github.com/apache/arrow-datafusion/pull/7570#discussion_r1327880925
########## datafusion/execution/src/cache/mod.rs: ########## @@ -0,0 +1,44 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +pub mod cache_manager; +pub mod cache_unit; + +// The cache accessor, users usually working on this interface while manipulating caches +pub trait CacheAccessor<K, V>: Send + Sync { + // Extra info but not part of the cache key or cache value. + type Extra: Clone; Review Comment: Like in default `FileStatisticsCache`, `get` func need check `last_modified` from `ObjectMeta` which not impl `Hash` so can not be part of the key, we need put this info in `Extra`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
