Ted-Jiang commented on code in PR #7570: URL: https://github.com/apache/arrow-datafusion/pull/7570#discussion_r1327881679
########## datafusion/execution/src/cache/cache_unit.rs: ########## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::cache::CacheAccessor; +use dashmap::DashMap; +use datafusion_common::Statistics; +use object_store::path::Path; +use object_store::ObjectMeta; + +/// Collected statistics for files +/// Cache is invalided when file size or last modification has changed +#[derive(Default)] +pub struct FileStatisticsCache { + statistics: DashMap<Path, (ObjectMeta, Statistics)>, +} + +impl CacheAccessor<Path, Statistics> for FileStatisticsCache { + type Extra = ObjectMeta; + + /// Get `Statistics` for file location. + fn get(&self, k: &Path) -> Option<Statistics> { + self.statistics + .get(k) + .map(|s| Some(s.value().1.clone())) + .unwrap_or(None) + } + + /// Get `Statistics` for file location. Returns None if file has changed or not found. + fn get_with_extra(&self, k: &Path, e: &Self::Extra) -> Option<Statistics> { Review Comment: Yes , thanks for point this out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
