niyue commented on code in PR #37752:
URL: https://github.com/apache/arrow/pull/37752#discussion_r1327939330
##########
cpp/src/gandiva/exported_funcs.cc:
##########
@@ -0,0 +1,10 @@
+#include "exported_funcs.h"
+
+namespace gandiva {
+REGISTER_EXPORTED_FUNCS(ExportedStubFunctions);
+REGISTER_EXPORTED_FUNCS(ExportedContextFunctions);
+REGISTER_EXPORTED_FUNCS(ExportedTimeFunctions);
+REGISTER_EXPORTED_FUNCS(ExportedDecimalFunctions);
+REGISTER_EXPORTED_FUNCS(ExportedStringFunctions);
+REGISTER_EXPORTED_FUNCS(ExportedHashFunctions);
Review Comment:
All the `REGISTER_EXPORTED_FUNCS` are moved into a `exported_funcs.cc` file,
which makes the registration API to be called from 7 * 6 times down to 6 times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
