niyue commented on code in PR #37752:
URL: https://github.com/apache/arrow/pull/37752#discussion_r1327949221
##########
cpp/src/gandiva/engine.cc:
##########
@@ -319,6 +319,10 @@ Status Engine::FinalizeModule() {
// do the compilation
execution_engine_->finalizeObject();
+ ARROW_RETURN_IF(
+ execution_engine_->hasError(),
+ Status::CodeGenError("Compilation failed: ",
execution_engine_->getErrorMessage()));
Review Comment:
It turns out this `hasError` API is only available in some (newer) version
of LLVM, I reverted this piece of change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
