jayzhan211 commented on code in PR #7577:
URL: https://github.com/apache/arrow-datafusion/pull/7577#discussion_r1327958251
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -520,6 +520,12 @@ async fn test_string_expressions_batch2() -> Result<()> {
"split_part('abc~@~def~@~ghi', '~@~', CAST(NULL AS INT))",
"NULL"
);
+ test_expression!("string_to_array(NULL, ' ')", "NULL");
Review Comment:
You just need to leave the test in sqllogictest, it is the preferred one.
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -1277,6 +1291,7 @@ fn aliases(func: &BuiltinScalarFunction) -> &'static
[&'static str] {
BuiltinScalarFunction::Rpad => &["rpad"],
BuiltinScalarFunction::Rtrim => &["rtrim"],
BuiltinScalarFunction::SplitPart => &["split_part"],
+ BuiltinScalarFunction::StringToArray => &["string_to_array"],
Review Comment:
We may need string_to_list too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
