casperhart commented on code in PR #7577:
URL: https://github.com/apache/arrow-datafusion/pull/7577#discussion_r1328180424


##########
datafusion/sqllogictest/test_files/functions.slt:
##########
@@ -753,6 +743,32 @@ SELECT string_to_array('abc def', ' ', 'def')
 ----
 [abc, ]
 
+statement ok
+create table strings (value varchar) as values 
+  ('foo'), 
+  ('abc def ghi'), 
+  (' '), 
+  (NULL);
+
+query ?
+select string_to_array(value, ' ') from strings;
+----
+[foo]
+[abc, def, ghi]
+[, ]
+NULL
+
+query ?
+select string_to_list(value, ' ') from strings;
+----
+[foo]
+[abc, def, ghi]
+[, ]
+NULL
+
+statement ok

Review Comment:
   I've used an existing table from `array.slt` so removed the create table / 
drop table statements entirely



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to