Joseph-Rance commented on code in PR #4773:
URL: https://github.com/apache/arrow-rs/pull/4773#discussion_r1329855353
##########
parquet_derive/src/parquet_field.rs:
##########
@@ -682,6 +838,66 @@ impl Type {
}
}
+// returns quote of function needed to convert from parquet
+// types back into the types used in the struct fields.
+pub fn get_convertable_quote() -> proc_macro2::TokenStream {
Review Comment:
fixed in
[9f2dd9f](https://github.com/apache/arrow-rs/pull/4773/commits/9f2dd9f901462b6221bc7ba9fab04343c85469b6)
##########
parquet_derive/src/parquet_field.rs:
##########
@@ -524,6 +665,21 @@ impl Type {
}
}
+ fn physical_type_as_rust(&self) -> proc_macro2::TokenStream {
+ use parquet::basic::Type as BasicType;
+
+ match self.physical_type() {
+ BasicType::BOOLEAN => quote! { bool },
+ BasicType::INT32 => quote! { i32 },
+ BasicType::INT64 => quote! { i64 },
+ BasicType::INT96 => unimplemented!("96-bit int currently is not
supported"),
+ BasicType::FLOAT => quote! { f32 },
+ BasicType::DOUBLE => quote! { f64 },
+ BasicType::BYTE_ARRAY => quote! { ::parquet::data_type::ByteArray
},
+ BasicType::FIXED_LEN_BYTE_ARRAY => quote! {
::parquet::data_type::ByteArray },
Review Comment:
fixed in
[9f2dd9f](https://github.com/apache/arrow-rs/pull/4773/commits/9f2dd9f901462b6221bc7ba9fab04343c85469b6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
