kou commented on code in PR #37783:
URL: https://github.com/apache/arrow/pull/37783#discussion_r1329421174
##########
cpp/src/arrow/ipc/read_write_test.cc:
##########
@@ -1519,6 +1519,23 @@ class ReaderWriterMixin : public ExtensionTypesMixin {
}
}
+ void TestWriteAfterClose() {
+ // Part of GH-35095.
+ std::shared_ptr<RecordBatch> batch_ints;
+ ASSERT_OK(MakeIntRecordBatch(&batch_ints));
+
+ std::shared_ptr<Schema> schema = batch_ints->schema();
+
+ WriterHelper writer_helper;
+ ASSERT_OK(writer_helper.Init(schema, IpcWriteOptions::Defaults()));
+ ASSERT_OK(writer_helper.WriteBatch(batch_ints));
+ ASSERT_OK(writer_helper.Finish());
+
+ // Write after close raises status
+ auto foo = writer_helper.WriteBatch(batch_ints);
+ // ASSERT_RAISES(Invalid, writer_helper.WriteBatch(batch_ints));
Review Comment:
Why is this assertion commented out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
