chrisjordansquire commented on code in PR #37783:
URL: https://github.com/apache/arrow/pull/37783#discussion_r1330570852
##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -1070,6 +1070,9 @@ class ARROW_EXPORT IpcFormatWriter : public
RecordBatchWriter {
Status WriteRecordBatch(
const RecordBatch& batch,
const std::shared_ptr<const KeyValueMetadata>& custom_metadata) override
{
+ if (closed_) {
+ return Status::Invalid("Destination already closed");
+ }
Review Comment:
Good question.
It appears that WriteTable ultimately calls WriteRecordBatch. This appears
to be documented as well, in that the documentation for
RecordBatchWriter::WriteTable is that a a table is written by creating a
sequence of record batches. So testing WriteTable doesn't seem to be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
