[GitHub] [arrow] tschaub commented on a diff in pull request #37780: GH-37779: [Go] Link to the pkg.go.dev site for Go reference docs

[via GitHub]

tschaub commented on code in PR #37780:
URL: https://github.com/apache/arrow/pull/37780#discussion_r1329513337


##########
dev/release/post-11-bump-versions-test.rb:
##########
@@ -276,6 +276,34 @@ def test_version_post_tag
       next if hunks.empty?
       expected_changes << {hunks: hunks, path: path}
     end
+    if release_type == :major
+      expected_changes << {
+        hunks: [
+          [
+            "-[![Go 
Reference](https://pkg.go.dev/badge/github.com/apache/arrow/go/v#{@snapshot_major_version}.svg)](https://pkg.go.dev/github.com/apache/arrow/go/v#{@snapshot_major_version})",
+            "+[![Go 
Reference](https://pkg.go.dev/badge/github.com/apache/arrow/go/v#{@next_major_version}.svg)](https://pkg.go.dev/github.com/apache/arrow/go/v#{@next_major_version})",
+          ],

Review Comment:
   Does `README.md` need to be added to [the glob 
above](https://github.com/apache/arrow/pull/37780/files#diff-ed4591fc42e3d74c25735a1cf85f0dff430649978397ea4cf94cd156ec6c5530R238)?
   
   I thought something like this might be required:
   ```diff
        end
    
   -    Dir.glob("go/**/{go.mod,*.go,*.go.*}") do |path|
   +    Dir.glob("go/**/{go.mod,*.go,*.go.*,README.md}") do |path|
          if path == "go/arrow/doc.go"
            expected_changes << {
              path: path,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org