[GitHub] [arrow] kou commented on a diff in pull request #37780: GH-37779: [Go] Link to the pkg.go.dev site for Go reference docs

Mon, 18 Sep 2023 22:31:08 -0700 


kou commented on code in PR #37780:
URL: https://github.com/apache/arrow/pull/37780#discussion_r1329593336


##########
dev/release/post-11-bump-versions-test.rb:
##########
@@ -276,6 +276,34 @@ def test_version_post_tag
       next if hunks.empty?
       expected_changes << {hunks: hunks, path: path}
     end
+    if release_type == :major
+      expected_changes << {
+        hunks: [
+          [
+            "-[![Go 
Reference](https://pkg.go.dev/badge/github.com/apache/arrow/go/v#{@snapshot_major_version}.svg)](https://pkg.go.dev/github.com/apache/arrow/go/v#{@snapshot_major_version})",
+            "+[![Go 
Reference](https://pkg.go.dev/badge/github.com/apache/arrow/go/v#{@next_major_version}.svg)](https://pkg.go.dev/github.com/apache/arrow/go/v#{@next_major_version})",
+          ],

Review Comment:
   If we want to use this approach, we also need to update the `Dir.glob` 
content. See 
https://github.com/apache/arrow/pull/37780/commits/d9f7f63155627b00b501bf2f024ba486911ba32f
 for details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to