pitrou commented on code in PR #37785:
URL: https://github.com/apache/arrow/pull/37785#discussion_r1331898274
##########
go/parquet/internal/bmi/bitmap_neon_arm64.s:
##########
@@ -27,8 +27,8 @@ LBB0_2:
MOVD R0, res+16(FP)
RET
LBB0_4:
- WORD $0xaa1f03e0 // mov x0, xzr
WORD $0xa8c17bfd // ldp x29, x30, [sp], #16
+ MOVD ZR, res+16(FP)
Review Comment:
> Without knowing how Yuqi originally generated the arm64 assembly, I'm not
sure what the cause of this was.
There should be a well-defined way to generate the assembly, so that other
people can later participate in maintenance.
(also, is it possible that the original arm64 assembly was simply out of
sync with the current C source?)
> The pure go impl already does it!
Nice, so you just need to port it to C now :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
